API testing additions: cipher tests#10174
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Apr 13, 2026
Merged
Conversation
SparkiDev
force-pushed
the
api_test_cipher_algs_1
branch
from
013483f to
431ef44
Compare
Contributor
Author
|
retest this please |
Fixed wc_AesEaxAuthDataUpdate to check eax for NULL before dereferencing. Fix AesSivCipher to delete/free AES if new/initialization succeeded. Memsetting to 0 doesn't work when WC_DEBUG_CIPHER_LIFECYCLE is defined. Added tests for: - AES-EAX streaming - AES-SIV - Poly1305 - DES-CBC
SparkiDev
force-pushed
the
api_test_cipher_algs_1
branch
from
431ef44 to
b764aac
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10174
Scan targets checked: wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-consttime, wolfcrypt-defaults, wolfcrypt-mutation, wolfcrypt-portability, wolfcrypt-proptest, wolfcrypt-src, wolfcrypt-zeroize
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
dgarske
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed wc_AesEaxAuthDataUpdate to check eax for NULL before dereferencing.
Fix AesSivCipher to delete/free AES if new/initialization succeeded.
Memsetting to 0 doesn't work when WC_DEBUG_CIPHER_LIFECYCLE is defined.
Added tests for:
Testing
./configure --disable-shared --enable-all