Skip to content

fix: unify call quality accessibility descriptions [WPB-24422]#4725

Merged
saleniuk merged 3 commits intodevelopfrom
fix/update-call-quality-details-accessibility
Apr 14, 2026
Merged

fix: unify call quality accessibility descriptions [WPB-24422]#4725
saleniuk merged 3 commits intodevelopfrom
fix/update-call-quality-details-accessibility

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented Apr 13, 2026

https://wearezeta.atlassian.net/browse/WPB-24422


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Talkback reads some call quality dashboard button actions as "double tap to activate" and for others is more specific with "double tap to view details". We want all buttons to have unified description - the action is the same so the description also should be the same.

Solutions

Remove custom action names for click labels.
Add the button name as contentDescription and move the part related to the state that changes to stateDescription - thanks to that state is read again when it changes, and the content is read only once after reading the state, but before "double tap to activate". So for the "view details" row with quality state, talkback reads it as: "network quality: good, view details, double tap to activate".

Testing

How to Test

Join/start a call, open call details, enable talkback and let it read the content.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

@saleniuk saleniuk requested a review from ohassine April 14, 2026 08:18
@saleniuk saleniuk added this pull request to the merge queue Apr 14, 2026
Merged via the queue into develop with commit fbf7eb4 Apr 14, 2026
17 checks passed
@saleniuk saleniuk deleted the fix/update-call-quality-details-accessibility branch April 14, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants