Skip to content

Add status PRECONDITION_FAILED to search filter#4847

Open
spectranaut wants to merge 1 commit intoweb-platform-tests:mainfrom
Igalia:status_precondition_failed
Open

Add status PRECONDITION_FAILED to search filter#4847
spectranaut wants to merge 1 commit intoweb-platform-tests:mainfrom
Igalia:status_precondition_failed

Conversation

@spectranaut
Copy link
Copy Markdown

@spectranaut spectranaut commented Apr 7, 2026

Description

Resolves #4672

The PRECONDITION_FAILED status already exists for subtests, so the filter is exactly like the other subtest status filters.

Review Information

Tests:

go test -tags=small -v ./api/query/cache/index -run TestBindExecute_TestStatus_PreconditionFailed
go test -tags=small -v ./shared/ -run TestPreconditionFailed

# And for the webapp tests:
$ ./util/docker-dev/web_server.sh
$ wptd_exec make web_components_test 

Changes

The change was ultimately quite simple, just adding the PRECONDITION_FAILED status where ever statuses were listed, and adding some tests.

As a follow up, I'd like to add a filter that just filters the PRECONDITION_FAILED tests from the subtest total, therefore, when comparing across different browsers/platforms, a PRECONDITION_FAILED will not look like a "not pass". With this filter, the subtest total across browser/platform runs may be different.

Requirements

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by PRECONDITION_FAILED subtest status

1 participant