Add status PRECONDITION_FAILED to search filter#4847
Open
spectranaut wants to merge 1 commit intoweb-platform-tests:mainfrom
Open
Add status PRECONDITION_FAILED to search filter#4847spectranaut wants to merge 1 commit intoweb-platform-tests:mainfrom
spectranaut wants to merge 1 commit intoweb-platform-tests:mainfrom
Conversation
57a8fe2 to
b4ddc9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4672
The PRECONDITION_FAILED status already exists for subtests, so the filter is exactly like the other subtest status filters.
Review Information
Tests:
Changes
The change was ultimately quite simple, just adding the PRECONDITION_FAILED status where ever statuses were listed, and adding some tests.
As a follow up, I'd like to add a filter that just filters the PRECONDITION_FAILED tests from the subtest total, therefore, when comparing across different browsers/platforms, a PRECONDITION_FAILED will not look like a "not pass". With this filter, the subtest total across browser/platform runs may be different.
Requirements
None.