Add simple finality itest by alexeykiselev · Pull Request #2063 · wavesplatform/gowaves

alexeykiselev · 2026-04-15T15:30:49Z

No description provided.

Simple two node finality test added.

Ordering of commitments state hash records fixed with new key.

Updated genesis.json configuration to support go/scala/no -mining. Enabled log level check added before querying latest finalized block height.

Copilot

Pull request overview

Adds a smoke integration test around deterministic finality (feature activation + commit-to-generation workflow across Go/Scala nodes) and adjusts supporting state-hash/config plumbing to make the scenario reproducible in itests.

Changes:

Add a new smoke itest suite for finality and introduce a dedicated feature settings JSON enabling finality support.
Update itests genesis/config plumbing to distinguish Go vs Scala mining key derivation (mining_type) and to pass generation-period length into node configs.
Adjust commitments state-hash keying to avoid overwriting hashed components when multiple commitments are stored.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
pkg/state/state.go	Adds info-level logging around finalization state during block apply.
pkg/state/keys.go	Introduces a special key type used for ordering/uniqueness in commitment state-hash tracking.
pkg/state/commitments.go	Adds `lastIndex()` and uses an indexed key for state-hash pushes when storing commitments.
itests/testdata/feature_settings/finality_supported_setting.json	New feature settings enabling deterministic finality support in itests.
itests/smoke_finality_internal_test.go	New smoke suite that commits to generation periods after finality activation.
itests/init_internal_test.go	Forces Docker client API version via environment variables during test setup.
itests/finality_internal_test.go	Renames wallet address constants and adds a Scala miner address constant.
itests/docker/docker.go	Also forces Docker client API version via environment variables in Docker helper.
itests/config/template.conf	Passes `generation-period-length` into the node configuration template.
itests/config/miningtype.go	Adds `MiningType` enum with `go:generate` for string/JSON helpers.
itests/config/miningtype_string.go	Generated enum string/JSON marshaling code for `MiningType`.
itests/config/genesis_settings.go	Switches genesis distribution from `is_miner` to `mining_type` and derives BLS keys differently for Go vs Scala mining.
itests/config/genesis.json	Updates genesis distributions to use `mining_type` and reformats preactivated features.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T10:35:44Z

+	// Set environment variables to enforce docker client connection with a required API version.
+	// Non-empty DOCKER_MACHINE_NAME allows to create client with DOCKER_API_VERSION.
+	if envErr := os.Setenv("DOCKER_MACHINE_NAME", "local"); envErr != nil {
+		return envErr
+	}
+	if envErr := os.Setenv("DOCKER_API_VERSION", "1.45"); envErr != nil {
+		return envErr
+	}


testsSetup() unconditionally overwrites DOCKER_MACHINE_NAME and DOCKER_API_VERSION for the whole process. This can break users/CI that intentionally set these variables (or rely on Docker’s negotiated API version). Consider only setting them when they are not already set (via os.LookupEnv) and/or centralizing this logic in one place (it’s duplicated in itests/docker.NewDocker).

Added a function to check for an environment variable and set it only if it is not already defined.

Copilot · 2026-04-16T10:35:46Z

+	if slog.Default().Enabled(context.Background(), slog.LevelInfo) {
+		finalizedHeight, err := s.stor.finality.lastFinalizedHeight(blockHeight)
+		if err != nil {
+			return fmt.Errorf("failed to build local endorsement message: %w", err)
+		}
+		slog.Info("Current finalization state", slog.Uint64("finalizedHeight", finalizedHeight),


This changes the finalization log from slog.Debug to an Info log executed for every block while DeterministicFinality is active. That can produce very high log volume in normal runs; consider keeping it at debug (or sampling/throttling) and/or using Enabled(..., slog.LevelDebug) to avoid expensive lookups without increasing default verbosity.

Suggested change

if slog.Default().Enabled(context.Background(), slog.LevelInfo) {

finalizedHeight, err := s.stor.finality.lastFinalizedHeight(blockHeight)

if err != nil {

return fmt.Errorf("failed to build local endorsement message: %w", err)

}

slog.Info("Current finalization state", slog.Uint64("finalizedHeight", finalizedHeight),

if slog.Default().Enabled(context.Background(), slog.LevelDebug) {

finalizedHeight, err := s.stor.finality.lastFinalizedHeight(blockHeight)

if err != nil {

return fmt.Errorf("failed to build local endorsement message: %w", err)

}

slog.Debug("Current finalization state", slog.Uint64("finalizedHeight", finalizedHeight),

Nope, this is ok.

Guess the Enabled check is redundant here, because users mostly use logger at INFO level. What do you think?

Function to retrieve and compare finalized blocks heights added and called in test.

nickeskov · 2026-04-17T01:33:58Z

+// commitmentStateHashKey is used only to correctly order legacy state hash record.
+// WARNING! Do not use the key for any storage operations.


Maybe move it to a new file? (state_hasher_keys.go, for example)

nickeskov · 2026-04-17T02:03:47Z

+	if slog.Default().Enabled(context.Background(), slog.LevelInfo) {
+		finalizedHeight, err := s.stor.finality.lastFinalizedHeight(blockHeight)
+		if err != nil {
+			return fmt.Errorf("failed to build local endorsement message: %w", err)
+		}
+		slog.Info("Current finalization state", slog.Uint64("finalizedHeight", finalizedHeight),


Guess the Enabled check is redundant here, because users mostly use logger at INFO level. What do you think?

Section about env vars added to itest README.

nickeskov

LGTM

alexeykiselev added the wip This is a WIP, should not be merged right away label Apr 15, 2026

Base automatically changed from generators-set to determenistic-finality-feature April 16, 2026 07:45

alexeykiselev added 4 commits April 16, 2026 12:03

WIP: Base itest suite added with support of feature 25 added.

38b9a0d

Fixed Docker connection API version.

5898f71

Simple two node finality test added.

Rise level of log message.

9982d9f

Scala node commitment for generation added to finality smoke itest.

4d4bd2d

Ordering of commitments state hash records fixed with new key.

alexeykiselev force-pushed the add-simple-finality-itest branch from dfa1861 to 4d4bd2d Compare April 16, 2026 08:04

Correct BLS keys generation for Go and Scala miners.

9c31ae1

Updated genesis.json configuration to support go/scala/no -mining. Enabled log level check added before querying latest finalized block height.

alexeykiselev removed the wip This is a WIP, should not be merged right away label Apr 16, 2026

alexeykiselev requested review from Copilot, irina-pereiaslavskaia and nickeskov and removed request for irina-pereiaslavskaia and nickeskov April 16, 2026 10:30

Copilot started reviewing on behalf of alexeykiselev April 16, 2026 10:30 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

alexeykiselev added 2 commits April 16, 2026 15:53

Fixed BLS key generation for non-mining accounts.

87e51e6

Copilot review issues fixed.

16778ec

Function to retrieve and compare finalized blocks heights added and called in test.

irina-pereiaslavskaia approved these changes Apr 16, 2026

View reviewed changes

irina-pereiaslavskaia had a problem deploying to ITests April 16, 2026 17:00 — with GitHub Actions Error

nickeskov reviewed Apr 17, 2026

View reviewed changes

Review fixes.

7245f18

Section about env vars added to itest README.

alexeykiselev requested a review from nickeskov April 17, 2026 08:34

nickeskov reviewed Apr 17, 2026

View reviewed changes

nickeskov merged commit a9ae9e4 into determenistic-finality-feature Apr 17, 2026
11 checks passed

nickeskov deleted the add-simple-finality-itest branch April 17, 2026 13:28

		// commitmentStateHashKey is used only to correctly order legacy state hash record.
		// WARNING! Do not use the key for any storage operations.

Conversation

alexeykiselev commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

alexeykiselev Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

alexeykiselev Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

nickeskov Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nickeskov Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nickeskov Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nickeskov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants