allow pod controller config overrides#1309
allow pod controller config overrides#1309alec-rabold wants to merge 1 commit intovirtual-kubelet:mainfrom
Conversation
alec-rabold
force-pushed
the
feature/pod-controller-config-overrides
branch
from
b7b4410 to
7a5eacc
Compare
pires
force-pushed
the
feature/pod-controller-config-overrides
branch
from
c387bd7 to
4dd3606
Compare
pires
added
enhancement
help wanted
go
|
This breaks code badly :-( |
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
This breaks code badly :-( Please, fix.
|
@alec-rabold did you end up using these changes in your provider? It seems the changes are incomplete and it would be great to consider this for inclusion soon 🙏🏻 |
hey @pires sorry for the delay, we ended up not using this specific config but I do think it would still be beneficial; I'll spend some time today fixing this up to pass the unit/e2e tests |
alec-rabold
force-pushed
the
feature/pod-controller-config-overrides
branch
from
4dd3606 to
ede3100
Compare
|
updated! (and verified the unit tests and e2e suite passes) I don't love the nested options style I've added, but should work |
|
kindly ping, what's the status of this PR? This PR would be helpful to customize rate limit and decrease the latency when there is a lot of pods to handle. @pires |
|
I need to digest this further as it breaks the current API. |
3 participants
Allow overriding pod controller config options
Current use-case is for
SyncPodsFromKubernetesRateLimiter+SyncPodsFromKubernetesShouldRetryFunc-- specifically to infinitely retry for certain errors instead of stopping at 20 attempts (e.g. similar toImagePullBackoff)