Fix MacOS torch multiprocessing permission issue#13709
Conversation
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
|
👋 Hello @Y-T-G, thank you for submitting a -✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Overall clean change and well-scoped to macOS CI. One potential robustness issue: the new chmod (and import) can fail when torch_shm_manager isn’t present, which could break macOS runs.
💬 Posted 1 inline comment
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Overall looks good and targeted to macOS CI stability. Only concern is making the chmod step resilient to torch builds that don’t include torch_shm_manager.
💬 Posted 1 inline comment
|
@Laughing-q MacOS security blocks torch for some reason. |
|
@Y-T-G just saw this one, merged! |
|
🎉 Huge thanks to @Y-T-G for this excellent contribution, with support from @glenn-jocher on getting it across the finish line! By adding this thoughtful macOS CI workaround for PyTorch multiprocessing, you’ve helped make testing in Really appreciate the care and practical problem-solving here — merged improvements like this make the whole project stronger 🚀 |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR improves macOS CI reliability in
ultralytics/yolov5by adding a security-policy workaround for PyTorch multiprocessing ✅🍎📊 Key Changes
.github/workflows/ci-testing.yml.xattr.torch_shm_managerhelper binary executable withchmod +x.🎯 Purpose & Impact