get a specified value in the access token#888
Open
hendeavors wants to merge 2 commits intothephpleague:masterfrom
hendeavors:getaccesstokenvalue
Open
get a specified value in the access token#888hendeavors wants to merge 2 commits intothephpleague:masterfrom hendeavors:getaccesstokenvalue
hendeavors wants to merge 2 commits intothephpleague:masterfrom
hendeavors:getaccesstokenvalue
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #888 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 180 185 +5
===========================================
Files 20 20
Lines 464 472 +8
===========================================
+ Hits 464 472 +8
🚀 New features to boost your workflow:
|
shadowhand
requested changes
Oct 26, 2022
Comment on lines
+217
to
+219
| if (!(is_string($offset) || is_numeric($offset))) { | ||
| throw new InvalidArgumentException("Values offset must be a string or int"); | ||
| } |
Member
There was a problem hiding this comment.
What is the point of this check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide the ability to get a value from the access token by the offset.
Before:
$value = $token->getValues()['some_offset'] ?? null;After:
$value = $token->getValue('some_offset');