Skip to content

web: add vault lock timer setting#9395

Merged
thecodrr merged 6 commits intobetafrom
web/vault-lock-timer-setting
Apr 15, 2026
Merged

web: add vault lock timer setting#9395
thecodrr merged 6 commits intobetafrom
web/vault-lock-timer-setting

Conversation

@01zulfi
Copy link
Copy Markdown
Member

@01zulfi 01zulfi commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

{
type: "dropdown",
options: [
{ title: "1 minute", value: 1000 * 60 * 1 },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an Immediately option in which we don't store the password at all.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't store the password, then when a note is unlocked, it won't be able to be edited and will throw the vault locked error

index.mjs:20  2026-02-25T09:09:46.953Z | ERROR | [notesnook-web]: Error: ERR_VAULT_LOCKED
    at Vault.<anonymous> (vault.js:229:23)
    at Generator.next (<anonymous>)
    at fulfilled (http://localhost:3000/@fs/home/zulfi/code/notesnook/notesnook/packages/core/dist/esm/api/vault.js:22:58) {} [62ms]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Cloudflare Pages Preview

https://f83defcc.notesnook-app.pages.dev

Commit: 7550fc7

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Desktop Previews

Commit: 7550fc7

Copy link
Copy Markdown
Collaborator

@ayesha004tanveer-netizen ayesha004tanveer-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@01zulfi

Bug Title:
No notification when vault auto-locks

Description:
When you lock the vault manually, the app shows a notification saying “Vault locked.” But if the vault locks automatically using the timer, no notification appears.

Steps to Reproduce:

  1. Open the app.
  2. Lock the vault manually → see the “Vault locked” notification.
  3. Go to settings and enable auto-lock (set timer to 1 minute).
  4. Wait for 1 minute and see what happens.

Expected Result:
A notification should appear when the vault locks automatically, just like the manual lock.

Actual Result:
No notification appears when the vault auto-locks.

Reference Screenshot attached:

Image

Copy link
Copy Markdown
Collaborator

@ayesha004tanveer-netizen ayesha004tanveer-netizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.88.webm

@01zulfi

Bug Title:
Vault locks immediately after selecting auto-lock time

Description:
When I select an auto-lock time (like 5 or 10 minutes), the vault locks right away. After unlocking, it locks again after the selected time, which is correct. But it should not lock immediately when I choose the time.

Steps to Reproduce:

  1. Go to vault settings.
  2. Select an auto-lock time (5 or 10 minutes).
  3. See that the vault locks immediately.
  4. Unlock the vault and wait, the vault locks again after the selected time.

Expected Result:
The vault should lock only after the selected time passes.

Actual Result:
The vault locks immediately on selecting the option

Bug Video is attached:

01zulfi and others added 2 commits April 13, 2026 11:40
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
@01zulfi 01zulfi force-pushed the web/vault-lock-timer-setting branch from efcc312 to 8a83a1a Compare April 14, 2026 08:45
@thecodrr thecodrr merged commit 534cf88 into beta Apr 15, 2026
11 checks passed
@thecodrr thecodrr deleted the web/vault-lock-timer-setting branch April 15, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants