Skip to content

feat: add blas/ext/base/gwhere#11345

Merged
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:blas/gwhere
Apr 17, 2026
Merged

feat: add blas/ext/base/gwhere#11345
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:blas/gwhere

Conversation

@headlessNode
Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#251.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/gwhere

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Apr 9, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 9, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gwhere $\color{green}337/337$
$\color{green}+0.00%$
$\color{green}21/21$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}337/337$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Apr 9, 2026
@headlessNode headlessNode marked this pull request as draft April 10, 2026 14:20
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 10, 2026
@headlessNode headlessNode added the Needs Changes Pull request which needs changes before being merged. label Apr 10, 2026
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 15, 2026
@headlessNode headlessNode marked this pull request as ready for review April 15, 2026 04:39
@headlessNode headlessNode requested a review from kgryte April 15, 2026 04:40
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/lib/ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/lib/accessors.js Outdated
Co-authored-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 16, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/lib/ndarray.js Outdated
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial comment.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 16, 2026
@headlessNode headlessNode requested a review from a team April 16, 2026 13:01
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 16, 2026
@headlessNode headlessNode requested a review from kgryte April 16, 2026 13:05
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Apr 16, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 17, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gwhere/benchmark/benchmark.ndarray.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 17, 2026

As the CI failure is expected, I'll go ahead and merge. Ref: #dev-questions > TypeScript lint errors. The issue stems from lack of Float16Array support in our current version of TypeScript.

@kgryte kgryte merged commit 85b48f1 into stdlib-js:develop Apr 17, 2026
12 of 13 checks passed
@headlessNode headlessNode deleted the blas/gwhere branch April 17, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/gwhere

3 participants