Skip to content

Fix detection of test errors#2373

Merged
bert-e merged 7 commits intodevelopment/2.14from
improvement/ZENKO-5250
Apr 15, 2026
Merged

Fix detection of test errors#2373
bert-e merged 7 commits intodevelopment/2.14from
improvement/ZENKO-5250

Conversation

@francoisferrand
Copy link
Copy Markdown
Contributor

Ensure we don't ignore test failure, through 2 layers for additional safety:

  • test status validation (in archive-artifacts) now requires a non-empty test report: so test cannot unexpectedly passed due to infra or setup failure
  • remove the continue-on-error, and configure test framework to exit without error after test failure (and only in that case). Thus any setup/infra/build/... would still cause the step to fail

These limitation already caused some errors to be missed, and in particular mocha test refactoring actually broke the generation of test report (now fixed).

Issue: ZENKO-5250

@francoisferrand francoisferrand requested review from a team, delthas and maeldonn April 10, 2026 16:05
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 10, 2026

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Apr 13, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 13, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand francoisferrand force-pushed the improvement/ZENKO-5250 branch 5 times, most recently from 15c4122 to 14840db Compare April 14, 2026 14:46
@francoisferrand
Copy link
Copy Markdown
Contributor Author

/approve

francoisferrand and others added 7 commits April 15, 2026 20:47
- When archiving artifacts, _require_ tests to have passed. If no tests
  were executed (e.g. infra failure...) the job will still fail.
- As extra safety, tweak test runners (mocha, cucmber-js) to have exit
  code 0 on test failure: so we can remove the `continue-on-error` from
  the workflow. This behavior is enabled on in CI.

Issue: ZENKO-5250
The path was correct when mocha was run inside a consider; but is not
consistent with what is expected by archive-artifacts anymore.

Due to a gap in the workflow, this was missed when doing the change, and
these test results were actually ignored...

Issue: ZENKO-5250
It was removed from SDK, now in @smithy

Issue: ZENKO-5250
@francoisferrand francoisferrand force-pushed the improvement/ZENKO-5250 branch from 14840db to cc68501 Compare April 15, 2026 18:48
@scality scality deleted a comment from bert-e Apr 15, 2026
@scality scality deleted a comment from bert-e Apr 15, 2026
@scality scality deleted a comment from bert-e Apr 15, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 15, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.14

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-5250.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit cc68501 into development/2.14 Apr 15, 2026
14 checks passed
@bert-e bert-e deleted the improvement/ZENKO-5250 branch April 15, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants