Fix detection of test errors#2373
Merged
bert-e merged 7 commits intodevelopment/2.14from Apr 15, 2026
Merged
Conversation
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
SylvainSenechal
approved these changes
Apr 13, 2026
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
maeldonn
approved these changes
Apr 13, 2026
15c4122 to
14840db
Compare
Contributor
Author
|
/approve |
- When archiving artifacts, _require_ tests to have passed. If no tests were executed (e.g. infra failure...) the job will still fail. - As extra safety, tweak test runners (mocha, cucmber-js) to have exit code 0 on test failure: so we can remove the `continue-on-error` from the workflow. This behavior is enabled on in CI. Issue: ZENKO-5250
The path was correct when mocha was run inside a consider; but is not consistent with what is expected by archive-artifacts anymore. Due to a gap in the workflow, this was missed when doing the change, and these test results were actually ignored... Issue: ZENKO-5250
It was removed from SDK, now in @smithy Issue: ZENKO-5250
14840db to
cc68501
Compare
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-5250. Goodbye francoisferrand. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we don't ignore test failure, through 2 layers for additional safety:
These limitation already caused some errors to be missed, and in particular mocha test refactoring actually broke the generation of test report (now fixed).
Issue: ZENKO-5250