Add common Sass TypeScript configuration to the analysis package#2333
Add common Sass TypeScript configuration to the analysis package#2333
Conversation
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
should the eslint config be migrated to flat config first instead of exposing a config in the old format ? Eslint 9 does not support legacy configs anymore.
| "copyfiles": "^2.4.1", | ||
| "eslint-plugin-import": "^2.30.0", | ||
| "expect": "^29.7.0", | ||
| "gts": "^5.0.0", |
There was a problem hiding this comment.
is it needed to still have a direct dependency on ègts or is the transitive dependency enough (sass-analysiswill use its owngts` dependency)
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "./node_modules/gts/tsconfig-google.json" | |||
There was a problem hiding this comment.
does this work if gts is hoisted differently ? It should probably use gts/tsconfig-google.json instead, relying on the node-style resolution of the package
|
Unfortunately, it seems that gts is still not compatible with eslint flat configs (google/gts#830). I don't think we can land this without either that or moving away from GTS entirely. |
2 participants
No description provided.