test(cli): cover event remove command contracts#121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent CLI help/example work covered
event add, butevent removestill had an untested contract gap. The noun-first parser pathrc bucket event remove ...also had no dedicated assertion. That left a regression hole in a recently changed area of the command surface.This change adds focused coverage for both paths and fixes the missing help example output on the remove subcommand itself.
RemoveArgsnow exposes anafter_helpexample block so the top-level and noun-first help text both advertise the remove workflow consistently.Root cause
The event command group defined shared help examples at the group level and dedicated examples for
add, butremovehad no subcommand-specificafter_help. Help-contract coverage also skipped bothrc event removeandrc bucket event remove, so the missing examples were never asserted.Validation
I first added the new help-contract assertions, which failed because
event removehelp did not include an examples section. After adding the remove-specificafter_help, the targeted help-contract test passed.The repository does not contain a
Makefileorjustfile, somake pre-commitcannot run in this checkout. I ran the equivalent required validations directly instead:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace