Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a focused regression test for the recent CORS bucket-path normalization fix. The new assertion covers
local/, where the bucket segment becomes empty after trimming trailing slashes.Problem
The recent fix in
parse_bucket_pathrejects bucket paths whose bucket segment normalizes to an empty string. The existing test only coveredlocal///, so the simplerlocal/input remained untested even though it exercises the same user-facing edge case.Root Cause
The implementation was corrected, but the regression coverage did not include the shortest form of the empty normalized bucket path. That left the fix vulnerable to accidental changes in the parser contract.
Fix
I extended the existing parser error test in
crates/cli/src/commands/cors.rswith an assertion thatparse_bucket_path("local/")returns an error. The scope stays limited to the changed parser behavior and avoids unrelated command changes.Validation
I ran:
cargo test -p rustfs-cli test_parse_bucket_path_errorcargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceNote: this repository does not currently contain a
make pre-committarget, so I ran the underlying CI-equivalent checks directly.