Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused integration coverage for the bucket CORS stdin input path that was introduced with the recent bucket CORS command work.
The recent CORS feature added support for
rc bucket cors set <bucket> -, but the integration suite did not exercise that branch. That left a gap around piping configuration into the CLI, which is a user-facing path distinct from file-based input.This patch keeps scope tight by adding a small helper for spawning
rcwith piped stdin inside the existing integration harness and one test that writes a JSON CORS configuration through stdin, applies it withbucket cors set, and then verifies throughbucket cors list --jsonthat the stored rule matches the expected normalized methods.Validation
I attempted to run
make pre-commit, but this repository does not contain aMakefileor apre-committarget. I ran the documented repository checks directly instead:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacecargo test -p rustfs-cli --features integration test_bucket_cors_set_accepts_stdin_source -- --nocaptureThe new integration test follows the existing pattern of skipping when the S3 integration environment is not configured.