Another dateOnly option implementation, plus a minor ISO8601 parsing improvement#48
Open
cameron314 wants to merge 9 commits intormm5t:masterfrom
Open
Another dateOnly option implementation, plus a minor ISO8601 parsing improvement#48cameron314 wants to merge 9 commits intormm5t:masterfrom
cameron314 wants to merge 9 commits intormm5t:masterfrom
Conversation
…nt (which is valid under ISO8601)
Having timeago display datediff and timediff was required on page. To provide this ability, the format of display is determined by the initial value. The option to show dateOnly can also be controlled through timeago.settings
Auto determine the need of Date + DateTime display.
Made parsing account for timezone offsets that have no minute component (which is valid under ISO8601)
data-tz-change="utc2local" attribute on element will covert the specified time to Localtime. This is a stop-gap implementation, it can be further improved.
Enabled timeago computation reference UTC value (instead of Local timezone), Control using the attribute "data-tz-utc" on DOM element. XDate (https://github.com/arshaw/xdate) library is required at runtime.
Updated enhancement of UTC-to-Localtime support in README.markdown
[Pull request] Enhancement: Compute difference in UTC mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you want to pull this into the master or not, but I thought I should let you decide. Thanks for the original, it rocks!