@reach/portal: Support Remounting in <Activity>#999
Open
Conversation
🦋 Changeset detectedLatest commit: 87bf502 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the
portalNoderef is reset tonullwhen removing theportalNodeelement from the DOM. Without this the<Portal>doesn't properly re-add a node to the DOM when it's remounted inside of React's<Activity>component.Next.js 16's Cache Components use
<Activity>to restore UI when navigating back via history, so without this change navigating backwards in history can break portals.Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
yarn test).yarn start).This pull request:
If creating a new package:
examplesdirectorysrcdirectory with anindex.tsxentry filestyle.cssfile (if needed by the new package)