Improved table look (border color and size)#582
Improved table look (border color and size)#582BlueFox4 wants to merge 2 commits intopanr:masterfrom
Conversation
|
Could you upload screenshots with diff between changes? |
I wasn't sure for a moment what you referred to with "didn't really theme it correctly" and was a bit scared that I broke something I wasn't aware of, but... Now I see that everything is fine with the default version. The reason that tables look like they look is that I want you to focus on a content, not on styling. With your version, all I see is a table, not its content. Borders are too prominent and therefore they draw too much attention. Feel free to change it on you own fork 👍 |
|
Okay, i can understand your minimalist point (I just thought that it would be more coherent as e.g. images have the same border and thus used the phrase "not correctly themed"). Putting the color and line width aside, is it wanted that the table ist not as wide as the rest of the content / images? Should we at least change the table width to 100% to "fix" that (if it's not wanted of course!)? |


As I'm now using the theme in production for over a year, i created a table and was surprised the theme didn't really theme it correctly. This PR makes the following changes in main.css:
Thanks for your great theme!