Skip to content

NO-ISSUE: Added perodic job for longrunning testsuite for 4.21#77488

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
BhargaviGudi:node-long-running
Apr 14, 2026
Merged

NO-ISSUE: Added perodic job for longrunning testsuite for 4.21#77488
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
BhargaviGudi:node-long-running

Conversation

@BhargaviGudi
Copy link
Copy Markdown
Contributor

@BhargaviGudi BhargaviGudi commented Apr 7, 2026

The PR adds a periodic job that runs once in 24 hours.
Its configured to be informing
The test suite was added in openshift/origin#30976

Note: pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.

Summary by CodeRabbit

Tests

  • Added new periodic test job for AWS disruptive long-running test scenarios in OpenShift nightly 4.21 release validation. This job executes daily at 12:00 UTC using AWS infrastructure with SSH-enabled remote access capabilities and includes system resource monitoring and observer functionality to track system behavior during extended test scenarios.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@BhargaviGudi: This pull request explicitly references no jira issue.

Details

In response to this:

The PR adds a periodic job that runs once in 24 hours.
Its configured to be informing
The test was added in openshift/origin#30976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@BhargaviGudi: This pull request explicitly references no jira issue.

Details

In response to this:

The PR adds a periodic job that runs once in 24 hours.
Its configured to be informing
The test was added in openshift/origin#30976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cpmeadors
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2026
@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-disruptive-longrunning

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 10, 2026
@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

Note: pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.

@petr-muller
Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

Walkthrough

Added a new scheduled test job e2e-aws-disruptive-longrunning to the OpenShift release nightly 4.21 configuration with cron schedule 0 12 * * *. Added corresponding periodic job declaration in the periodics YAML file to execute the openshift-e2e-aws-disruption workflow on AWS infrastructure.

Changes

Cohort / File(s) Summary
New AWS disruption test job
ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml, ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml
Added e2e-aws-disruptive-longrunning test job entry (+12 lines) configured with TEST_SUITE=openshift/disruptive-longrunning, TEST_TYPE=suite, TEST_REQUIRES_SSH=yes, targeting openshift-org-aws cluster profile with observers-resource-watch observer enabled. Corresponding periodic job declaration (+84 lines) created with ci-operator container spec, multiple secret mounts (boskoos, GCS, pull credentials), and resource requests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive PR modifies only CI/CD configuration YAML files, not Ginkgo test code, so test name stability cannot be assessed. The custom check for dynamic Ginkgo test names is not applicable as no test definitions were modified.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a periodic job for the longrunning testsuite for 4.21, which matches the changeset that adds test job configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality ✅ Passed PR modifies only CI job configuration YAML files, not Ginkgo test code. Custom check for test code quality is not applicable.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration files (YAML) in openshift/release repository and does not add any new Ginkgo e2e test source code. The actual test source code is defined in openshift/origin repository. Since the MicroShift Test Compatibility check assesses new Ginkgo e2e tests for API compatibility and this PR contains no test source code, the check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI configuration YAML files (ci-operator config and periodics), not Ginkgo test code. Actual tests are in openshift/origin repo.
Topology-Aware Scheduling Compatibility ✅ Passed Added files are CI job configuration (Prow periodics and ci-operator test specs) without pod scheduling constraints, deployment manifests, or operator code.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI infrastructure YAML configuration files without changes to OTE binary source code or executable code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies CI configuration files, not Ginkgo e2e test code. The actual test implementations are added in a separate PR, so no IPv4 or external connectivity issues in tests to assess.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2d52cfe and 2 for PR HEAD f586f33 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 016803b and 1 for PR HEAD f586f33 in total

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

@BhargaviGudi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-disruptive-longrunning f586f33 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-disruptive-longrunning

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@BhargaviGudi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-disruptive-longrunning N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot openshift-merge-bot bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml (1)

2163-2174: Consider setting an explicit job timeout for this longrunning suite.

Given the target name on Line 2163 (longrunning), adding a top-level timeout would make runtime expectations explicit and reduce accidental default-timeout failures.

♻️ Suggested refinement
 - as: e2e-aws-disruptive-longrunning
   cron: 0 12 * * *
+  timeout: 8h0m0s
   steps:
     cluster_profile: openshift-org-aws
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml`
around lines 2163 - 2174, The job definition for e2e-aws-disruptive-longrunning
lacks an explicit timeout, so add a top-level timeout field (e.g., timeout:
"6h") to the job spec to prevent relying on implicit defaults; update the block
that defines the job (the entry with as: e2e-aws-disruptive-longrunning and
workflow: openshift-e2e-aws-disruption) to include a timeout property with an
appropriate duration string to reflect the longrunning suite's expected maximum
runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml`:
- Around line 2163-2174: The job definition for e2e-aws-disruptive-longrunning
lacks an explicit timeout, so add a top-level timeout field (e.g., timeout:
"6h") to the job spec to prevent relying on implicit defaults; update the block
that defines the job (the entry with as: e2e-aws-disruptive-longrunning and
workflow: openshift-e2e-aws-disruption) to include a timeout property with an
appropriate duration string to reflect the longrunning suite's expected maximum
runtime.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 10429f77-b785-453c-9191-103203dfa4eb

📥 Commits

Reviewing files that changed from the base of the PR and between d5405f6 and 2900b7f.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 13, 2026
@ngopalak-redhat
Copy link
Copy Markdown
Contributor

@BhargaviGudi Can you provide a link to a successful run on the job?
May be I have overlooked

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

@ngopalak-redhat Testsuite was added here:openshift/origin#30976.
But pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.

@ngopalak-redhat
Copy link
Copy Markdown
Contributor

@ngopalak-redhat Testsuite was added here:openshift/origin#30976. But pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.

Refer to #77488 (comment)
We merged one test and then the change to the release repo.

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

@ngopalak-redhat Testsuite was added here:openshift/origin#30976. But pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.

Refer to #77488 (comment) We merged one test and then the change to the release repo.

Then I’ll test PR #30973 locally, and once it’s merged, I’ll test this PR as well.

@cpmeadors
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BhargaviGudi, cpmeadors, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81bf77c into openshift:main Apr 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants