NO-ISSUE: Added perodic job for longrunning testsuite for 4.21#77488
Conversation
|
@BhargaviGudi: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@BhargaviGudi: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-disruptive-longrunning |
|
@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note: pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in. |
|
/approve |
WalkthroughAdded a new scheduled test job Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
|
@BhargaviGudi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixed cluster profile error
f586f33 to
2900b7f
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml (1)
2163-2174: Consider setting an explicit job timeout for this longrunning suite.Given the target name on Line 2163 (
longrunning), adding a top-leveltimeoutwould make runtime expectations explicit and reduce accidental default-timeout failures.♻️ Suggested refinement
- as: e2e-aws-disruptive-longrunning cron: 0 12 * * * + timeout: 8h0m0s steps: cluster_profile: openshift-org-aws🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml` around lines 2163 - 2174, The job definition for e2e-aws-disruptive-longrunning lacks an explicit timeout, so add a top-level timeout field (e.g., timeout: "6h") to the job spec to prevent relying on implicit defaults; update the block that defines the job (the entry with as: e2e-aws-disruptive-longrunning and workflow: openshift-e2e-aws-disruption) to include a timeout property with an appropriate duration string to reflect the longrunning suite's expected maximum runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml`:
- Around line 2163-2174: The job definition for e2e-aws-disruptive-longrunning
lacks an explicit timeout, so add a top-level timeout field (e.g., timeout:
"6h") to the job spec to prevent relying on implicit defaults; update the block
that defines the job (the entry with as: e2e-aws-disruptive-longrunning and
workflow: openshift-e2e-aws-disruption) to include a timeout property with an
appropriate duration string to reflect the longrunning suite's expected maximum
runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 10429f77-b785-453c-9191-103203dfa4eb
📒 Files selected for processing (2)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yamlci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml
|
/pj-rehearse ack |
|
@BhargaviGudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@BhargaviGudi Can you provide a link to a successful run on the job? |
|
@ngopalak-redhat Testsuite was added here:openshift/origin#30976. |
Refer to #77488 (comment) |
Then I’ll test PR #30973 locally, and once it’s merged, I’ll test this PR as well. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BhargaviGudi, cpmeadors, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The PR adds a periodic job that runs once in 24 hours.
Its configured to be informing
The test suite was added in openshift/origin#30976
Note: pj-rehearse validation will fail because no tests are tagged with this suite yet in release-4.21. Tests are being added via openshift/origin#30973, but that PR depends on merging this CI job configuration first so the tests have a job to run in.
Summary by CodeRabbit
Tests