Skip to content

perf(json): cache JsonMapper instance in jsonMapper() #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincerevu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(json): cache JsonMapper instance in jsonMapper() #718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a164621
Optimize jsonMapper instantiation
vincerevu Apr 10, 2026
35fe9ee
Optimize jsonMapper instantiation
vincerevu Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion openai-java-core/src/main/kotlin/com/openai/core/ObjectMappers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ import java.time.ZoneId
import java.time.format.DateTimeFormatter
import java.time.temporal.ChronoField

fun jsonMapper(): JsonMapper =
// Cache the Jackson JsonMapper instance to avoid the massive performance overhead of
// registering modules and building the mapper on every single invocation.
// This single lazily-initialized instance is thread-safe and can be reused globally.
private val JSON_MAPPER: JsonMapper by lazy {
JsonMapper.builder()
.addModule(kotlinModule())
.addModule(Jdk8Module())
Expand Down Expand Up @@ -112,6 +115,9 @@ fun jsonMapper(): JsonMapper =
.disable(MapperFeature.AUTO_DETECT_IS_GETTERS)
.disable(MapperFeature.AUTO_DETECT_SETTERS)
.build()
}

fun jsonMapper(): JsonMapper = JSON_MAPPER

/** A serializer that serializes [InputStream] to bytes. */
private object InputStreamSerializer : BaseSerializer<InputStream>(InputStream::class) {
Expand Down