Skip to content

Add NullAway to muzzle#17718

Merged
trask merged 1 commit intoopen-telemetry:mainfrom
zeitlinger:nullaway-muzzle
Apr 17, 2026
Merged

Add NullAway to muzzle#17718
trask merged 1 commit intoopen-telemetry:mainfrom
zeitlinger:nullaway-muzzle

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Apr 8, 2026

Part of #15991

Enables NullAway for the muzzle module and adds required @Nullable annotations.

Files changed:

  • build.gradle.kts — enable otel.nullaway-conventions
  • ByteArrayUrl.java — @Nullable on getPermission() return
  • BytecodeWithUrl.java — @Nullable annotations
  • HelperInjector.java — @Nullable on constructor instrumentation parameter
  • TransformSafeLogger.java — @Nullable annotations
  • AgentCachingPoolStrategy.java — @Nullable on findLoadedClassMethod, getFindLoadedClassMethod() return, loaderRef; use requireNonNull before invoking; @Nullable on cached fields and getSuperClass() returns
  • AgentLocationStrategy.java — @Nullable annotations
  • AgentTooling.java — @Nullable annotations
  • HelperReferenceWrapper.java — @Nullable annotations
  • ReferenceCollectingClassVisitor.java, ReferenceCollector.java, ReferenceMatcher.java — @Nullable annotations
  • MuzzleCodeGenerator.java — @Nullable annotations
  • ClassRef.java — @Nullable annotations

Depends on: no dependencies

@zeitlinger
Add NullAway null-safety annotations to muzzle module
05131f4 
Part of open-telemetry#15991

Enables NullAway for the muzzle module and adds required @nullable annotations
to ByteArrayUrl, BytecodeWithUrl, HelperInjector, TransformSafeLogger,
AgentCachingPoolStrategy, AgentLocationStrategy, AgentTooling,
HelperReferenceWrapper, ReferenceCollectingClassVisitor, ReferenceCollector,
ReferenceMatcher, MuzzleCodeGenerator, and ClassRef.
This was referenced Apr 8, 2026
Open
Closed
@zeitlinger zeitlinger marked this pull request as ready for review April 9, 2026 10:02
@zeitlinger zeitlinger requested a review from a team as a code owner April 9, 2026 10:02
@laurit laurit added this to the v2.27.0 milestone Apr 15, 2026
@trask trask merged commit 8727ff2 into open-telemetry:main Apr 17, 2026
177 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zeitlinger @laurit @trask