feat(explorer): add about page and footer navigation links#222
feat(explorer): add about page and footer navigation links#222jaydeluca merged 1 commit intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for otel-ecosystem-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds an /about route to the Ecosystem Explorer UI and exposes it via new footer navigation links, addressing issue #183.
Changes:
- Introduces a new
AboutPagewith project background, goals, and contribution/help links. - Updates the global footer to include navigation to About, the GitHub repo, and opentelemetry.io.
- Adds unit tests covering basic rendering and key link presence/targets for the About page and footer.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ecosystem-explorer/src/features/about/about-page.tsx | New About page content and external links. |
| ecosystem-explorer/src/features/about/about-page.test.tsx | New tests for About page headings/sections and one href assertion. |
| ecosystem-explorer/src/components/layout/footer.tsx | Footer layout updated; adds About + external navigation links. |
| ecosystem-explorer/src/components/layout/footer.test.tsx | New tests validating footer links and targets. |
| ecosystem-explorer/src/App.tsx | Wires /about route into the router. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <a | ||
| href="https://github.com/open-telemetry/opentelemetry-ecosystem-explorer" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="hover:text-foreground transition-colors" | ||
| > | ||
| GitHub | ||
| </a> |
There was a problem hiding this comment.
The GitHub repository URL is hardcoded here but also appears elsewhere (e.g., AboutPage). To avoid future drift (repo rename/move), consider centralizing these external URLs in a shared constants module and importing them in both places.
|
Thank you for your contribution @adaumsilva! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Summary
/aboutpage with project goals, contribution guidance, bug reporting and feature request links, and a link to the CNCF Slack channelTest plan
AboutPage— heading, sections, and link hrefsFooter— About link, GitHub link, opentelemetry.io linknpm test)/aboutand footer links render correctly