Skip to content

feat(explorer): display semantic conventions as linked badges on inst…#220

Merged
jaydeluca merged 2 commits intoopen-telemetry:mainfrom
adaumsilva:feat/semantic-convention-display
Apr 11, 2026
Merged

feat(explorer): display semantic conventions as linked badges on inst…#220
jaydeluca merged 2 commits intoopen-telemetry:mainfrom
adaumsilva:feat/semantic-convention-display

Conversation

@adaumsilva
Copy link
Copy Markdown
Contributor

Summary

  • Adds a getSemanticConventionInfo utility that maps raw semantic convention
    enum values (e.g. HTTP_CLIENT_SPANS) to human-readable labels and links to
    the official OpenTelemetry specification docs
  • Renders semantic conventions as clickable linked badges in the instrumentation
    detail page, with a plain monospace fallback for any unknown values
  • Closes Java Agent Semantic convention display improvement #210

Test plan

  • Unit tests for getSemanticConventionInfo — known values, unknown values, empty string
  • Detail page tests — linked badges render with correct href and target, unknown values render as plain text, section is hidden when no conventions are present
  • All 144 JS tests pass (npm test)
  • All Python tests pass across all automation components

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 11, 2026

Deploy Preview for otel-ecosystem-explorer ready!

Name Link
🔨 Latest commit 05a3a8d
🔍 Latest deploy log https://app.netlify.com/projects/otel-ecosystem-explorer/deploys/69da708426e1da0008143baa
😎 Deploy Preview https://deploy-preview-220--otel-ecosystem-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@adaumsilva adaumsilva force-pushed the feat/semantic-convention-display branch from 5847027 to 6995c4f Compare April 11, 2026 15:37
@adaumsilva adaumsilva marked this pull request as ready for review April 11, 2026 15:40
@adaumsilva adaumsilva requested review from a team as code owners April 11, 2026 15:40
Comment thread ecosystem-explorer/src/features/java-agent/utils/format.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds richer semantic convention display to the Java Agent instrumentation detail page by mapping raw semconv enum values to human-friendly labels and linking to OpenTelemetry spec documentation, addressing issue #210.

Changes:

  • Introduces getSemanticConventionInfo and a semconv-to-(label,url) mapping utility.
  • Updates the instrumentation detail page to render known semantic conventions as external links and keep a fallback for unknown values.
  • Adds unit/UI tests covering known/unknown semantic convention rendering and section visibility.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
ecosystem-explorer/src/features/java-agent/utils/format.ts Adds SemanticConventionInfo, a mapping table, and getSemanticConventionInfo.
ecosystem-explorer/src/features/java-agent/utils/format.test.ts Adds unit tests for getSemanticConventionInfo.
ecosystem-explorer/src/features/java-agent/instrumentation-detail-page.tsx Renders semantic conventions as external links for known values with fallback rendering.
ecosystem-explorer/src/features/java-agent/instrumentation-detail-page.test.tsx Adds page tests for linked badges, unknown fallback, and hidden section behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ecosystem-explorer/src/features/java-agent/utils/format.ts
Comment thread ecosystem-explorer/src/features/java-agent/utils/format.ts Outdated
Comment thread ecosystem-explorer/src/features/java-agent/utils/format.ts Outdated
Copy link
Copy Markdown
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @adaumsilva !

@jaydeluca jaydeluca merged commit 94784d9 into open-telemetry:main Apr 11, 2026
12 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot bot commented Apr 11, 2026

Thank you for your contribution @adaumsilva! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java Agent Semantic convention display improvement

3 participants