Skip to content

ci: add markdown-link-check ignore patterns#2456

Merged
sxa merged 1 commit intonodejs:mainfrom
MikeMcC399:fix/markdown-link-check-patterns
Apr 13, 2026
Merged

ci: add markdown-link-check ignore patterns#2456
sxa merged 1 commit intonodejs:mainfrom
MikeMcC399:fix/markdown-link-check-patterns

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 commented Apr 13, 2026

Description

In .github/workflows/markdown-link-check.yml

In markdown_link_check_config.json

Motivation and Context

The workflow .github/workflows/markdown-link-check.yml is sporadically failing with Status 0 errors:

  [✖] https://musl.libc.org/ → Status: 0
  ERROR: 2 dead links found in ./README.md !
  [✖] https://www.etalabs.net/compare_libcs.html → Status: 0

See workflow logs

This is although the following manually executed commands are succeeding:

curl -I https://musl.libc.org/
curl -I https://www.etalabs.net/compare_libcs.html

Testing Details

On Ubuntu 24.04.4 LTS, with Node.js 24.14.1 LTS

npm install markdown-link-check@3.14.2 -g
find . -name "*.md"  ! -path "./.git/*" | xargs -n 1 markdown-link-check -c markdown_link_check_config.json

No dead links should be reported.

Also tested in GitHub Actions https://github.com/MikeMcC399/docker-node/actions/workflows/markdown-link-check.yml

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 13, 2026 15:07
@sxa sxa merged commit 0d5606d into nodejs:main Apr 13, 2026
2 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/markdown-link-check-patterns branch April 13, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants