Skip to content

fix(keepSyntax): correct regex to avoid unnecessary escaping of speci…#8420

Open
LuvForAirplanes wants to merge 1 commit intonextcloud:mainfrom
LuvForAirplanes:main
Open

fix(keepSyntax): correct regex to avoid unnecessary escaping of speci…#8420
LuvForAirplanes wants to merge 1 commit intonextcloud:mainfrom
LuvForAirplanes:main

Conversation

@LuvForAirplanes
Copy link
Copy Markdown

Before, when you would simply open a Markdown file that had Wikilinks in it, (for example: [[Test Link]] ) NextCloud would automatically escape the double brackets to look like this: [[Test]]
This caused programs like Obsidian to lose the linking capability. The regex in the keepSyntax.js file was corrected to handle characters individually.

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

…al characters

Signed-off-by: Micah Stauffer <micah@bakerstreet.solutions>
@LuvForAirplanes
Copy link
Copy Markdown
Author

Not sure why my sign off was rejected.

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@LuvForAirplanes
Copy link
Copy Markdown
Author

@max-nextcloud can you explain wny this was rejected?

@EdoardoCostantini
Copy link
Copy Markdown

Would love to see this merged! : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escaping of square brackets breaks links of embedded attachments for external Markdown Editor

2 participants