Skip to content

feat: update loading shares of table#2379

Merged
luka-nextcloud merged 1 commit intomainfrom
update-loading-table-shares
Apr 14, 2026
Merged

feat: update loading shares of table#2379
luka-nextcloud merged 1 commit intomainfrom
update-loading-table-shares

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented Mar 9, 2026

Update access control for viewing table shares and improves the user interface logic to ensure only authorized users can load share information.

  • The index method in ShareController.php now requires MANAGE permission instead of READ to access table shares, ensuring only users with management rights can view share information.

  • The indexView method in ShareController.php now requires MANAGE permission instead of READ to access view shares, ensuring only users with management rights can view share information.

  • In Dashboard.vue, the loadShares method now checks if the user can manage the table before loading its shares, preventing unauthorized users from accessing share data.

@luka-nextcloud luka-nextcloud added 3. to review Waiting for reviews security Security related ticket labels Mar 9, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Mar 9, 2026
@blizzz blizzz moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Apr 1, 2026
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the update-loading-table-shares branch from ca1f25a to fac3f80 Compare April 2, 2026 15:33
@luka-nextcloud luka-nextcloud merged commit a3344fb into main Apr 14, 2026
65 checks passed
@luka-nextcloud luka-nextcloud deleted the update-loading-table-shares branch April 14, 2026 05:32
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 14, 2026
@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable32

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 14, 2026
@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable33

@backportbot
Copy link
Copy Markdown

backportbot bot commented Apr 14, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/2379/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fac3f804

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2379/stable32

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/2379/stable32')
fatal: not a valid object name: 'origin/stable32'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot bot commented Apr 14, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/2379/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fac3f804

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2379/stable33

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/2379/stable33')
fatal: not a valid object name: 'origin/stable33'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot security Security related ticket

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants