feat: update loading shares of table#2379
Merged
luka-nextcloud merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
ca1f25a to
fac3f80
Compare
blizzz
approved these changes
Apr 13, 2026
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/2379/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fac3f804
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2379/stable32Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/2379/stable32') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/2379/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fac3f804
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2379/stable33Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/2379/stable33') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update access control for viewing table shares and improves the user interface logic to ensure only authorized users can load share information.
The
indexmethod inShareController.phpnow requiresMANAGEpermission instead ofREADto access table shares, ensuring only users with management rights can view share information.The
indexViewmethod inShareController.phpnow requiresMANAGEpermission instead ofREADto access view shares, ensuring only users with management rights can view share information.In
Dashboard.vue, theloadSharesmethod now checks if the user can manage the table before loading its shares, preventing unauthorized users from accessing share data.