Skip to content

Add args to CmdSeqIn#4962

Open
Lex-ari wants to merge 9 commits intonasa:develfrom
FireflySpace:Lex-ari-CmdSeqIn-args
Open

Add args to CmdSeqIn#4962
Lex-ari wants to merge 9 commits intonasa:develfrom
FireflySpace:Lex-ari-CmdSeqIn-args

Conversation

@Lex-ari
Copy link
Copy Markdown
Contributor

@Lex-ari Lex-ari commented Apr 7, 2026

Related Issue(s) #4942 #4662 #4181 fpy#27 fpy#30
Has Unit Tests (y/n) n
Documentation Included (y/n) n
Generative AI was used in this contribution (y/n) y

Change Description

Add a U8 array to CmdSeqIn to allow pass through arguments from SeqDisp to CmdSequencer / FpySequencer / etc

Rationale

This is a feature to pass through arguments from the SequenceDispatcher to Sequencers (current and future) that support it.

Testing/Review Recommendations

Ensure SequenceDispatch functionality is working, both on fprime and fpy side.
These changes should not break / altar core functionality.

Future Work

This is a chain of pull requests to support arguments in sequences. Future work includes:

  • Creating a tool to pass arguments to the GDS to start a sequence with arguments
  • Fpy#30 Future Work: Replacing arguments onto the Fpy stack
  • Discussion on call syntax for sequence with arguments within sequences
  • Documentation

AI Usage (see policy)

Claude Code v2.1.92 sonnet used to autocomplete and find instances where CmdSeqIn changes were required.
FPP coding was done by hand and claude was used to autocomplete C++ calls.
All lines of code were human reviewed.

@LeStarch @zimri-leisher

Comment thread default/config/AcConstants.fpp
Comment thread Svc/CmdSequencer/CmdSequencerImpl.cpp Outdated
Comment thread Svc/SeqDispatcher/SeqDispatcher.cpp Outdated
@zimri-leisher
Copy link
Copy Markdown
Collaborator

So is modifying the RUN going to be a separate PR? Why not just do it in this PR, I think they are related. New RUN_ARGS cmd for SeqDispatcher and update existing RUN cmd for FpySeq

Comment thread Svc/Seq/Seq.fpp
Comment thread Svc/FpySequencer/FpySequencer.cpp Outdated
Comment thread Svc/SeqDispatcher/SeqDispatcher.cpp Outdated
Comment thread Svc/FpySequencer/FpySequencer.cpp Outdated
Comment thread Svc/FpySequencer/FpySequencerStateMachine.fppi Outdated
Comment thread default/config/AcConstants.fpp Outdated
Comment thread Svc/FpySequencer/FpySequencerCommands.fppi
Comment thread Svc/FpySequencer/FpySequencerStateMachine.cpp Outdated
@LeStarch
Copy link
Copy Markdown
Collaborator

Port buffers approved.

Comment thread default/config/AcConstants.fpp Outdated
Copy link
Copy Markdown
Collaborator

@zimri-leisher zimri-leisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular work! Let's merge it.

@Lex-ari Lex-ari requested a review from LeStarch April 16, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants