Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
soyuka
reviewed
Apr 14, 2026
| * }|\stdClass | ||
| */ | ||
| public function jsonSerialize(): array | ||
| public function jsonSerialize(): array|object |
Contributor
There was a problem hiding this comment.
why the sudden change? Is it because of conformance test failing otherwise?
Member
Author
There was a problem hiding this comment.
Yes, exactly, we could also think of changing the entire json_encode behavior to force empty object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@modelcontextprotocol/conformance clientmodetests/Conformance/client.phpclient executable handlinginitialize,tools_call, andelicitationscenariosclient-conformance-testsMakefile target andclient-conformanceCI jobClientCapabilitiesandCallToolRequest([]→{})Test plan
make client-conformance-testspasses (baseline check green)make unit-testspasses (600 tests)make phpstanpassesmake cspasses🤖 Generated with Claude Code