Open
Conversation
Performance Report (Linux) ✅
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (macOS)
Legend
|
Performance Report (Windows) ➖
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
There was a problem hiding this comment.
Pull request overview
This PR improves unit test coverage for the pet-reporter JSON-RPC reporter by extracting the environment-kind filtering logic into a small helper that can be tested directly, and by adding serialization-focused tests for telemetry and log payloads.
Changes:
- Refactored the JSON-RPC reporter’s
report_onlyfiltering into a privateshould_report_environment()helper. - Added unit tests covering filter allow/reject behavior.
- Added unit tests verifying JSON serialization shape for telemetry payloads and log payloads.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-reporter/src/jsonrpc.rs | Extracts environment filtering into a helper and adds unit tests for filtering + telemetry/log JSON serialization. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
pet-reporterslice from the Coverage: ranked plan to move workspace coverage toward 90% #389 coverage plan.Validation:
Refs #389