Skip to content

test: add reporter jsonrpc coverage#421

Open
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-reporter
Open

test: add reporter jsonrpc coverage#421
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-reporter

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Summary:

Validation:

  • cargo test -p pet-reporter
  • cargo fmt --all
  • cargo clippy --all -- -D warnings

Refs #389

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 71ms 113ms 96ms -25ms -20.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 73.8%
Base Branch Coverage 73.6%
Delta .2% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 54ms 595ms 58ms -4ms
Full Refresh 141ms 28625ms 99ms 42ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 9ms 11ms 8ms 1ms 12.5%
Full Refresh 143ms 382ms 128ms 15ms 11.7%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig requested a review from Copilot April 12, 2026 08:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 70.03%
Base Branch Coverage 69.86%
Delta 0.17% ✅

Coverage increased! Great work!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves unit test coverage for the pet-reporter JSON-RPC reporter by extracting the environment-kind filtering logic into a small helper that can be tested directly, and by adding serialization-focused tests for telemetry and log payloads.

Changes:

  • Refactored the JSON-RPC reporter’s report_only filtering into a private should_report_environment() helper.
  • Added unit tests covering filter allow/reject behavior.
  • Added unit tests verifying JSON serialization shape for telemetry payloads and log payloads.
Show a summary per file
File Description
crates/pet-reporter/src/jsonrpc.rs Extracts environment filtering into a helper and adds unit tests for filtering + telemetry/log JSON serialization.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@karthiknadig karthiknadig marked this pull request as ready for review April 13, 2026 02:47
@karthiknadig karthiknadig enabled auto-merge (squash) April 13, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants