Docs: Update sync/s3.md with new UpCloud URL#15049
Docs: Update sync/s3.md with new UpCloud URL#15049pogsee wants to merge 1 commit intolaurent22:devfrom
Conversation
Edited the UpCloud section of the s3 readme to reflect new URL style, also provided a region example.
|
All contributors have signed the CLA ✍️ ✅ |
📝 WalkthroughWalkthroughUpdated S3 provider configuration documentation for UpCloud. Replaced the endpoint URL template format with the provider-supplied URL template and added an example region value to the Region field description. Changes
Suggested labels
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@readme/apps/sync/s3.md`:
- Line 79: Replace the vague placeholder in the URL template
`https://<string>.upcloudobjects.com` with
`https://<endpoint>.upcloudobjects.com` in the README entry so the placeholder
clearly indicates the UpCloud S3 endpoint; update the text near the URL example
that currently references "S3 endpoint" if needed to match the `<endpoint>`
placeholder.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c5e16b71-6721-4e4b-8711-cb51dc3298e1
📒 Files selected for processing (1)
readme/apps/sync/s3.md
| ## UpCloud | ||
| - URL: `https://<account>.<region>.upcloudobjects.com` (They will provide you with multiple URLs, the one that follows this pattern should work.) | ||
| - Region: required | ||
| - URL: `https://<string>.upcloudobjects.com` (Use the "S3 endpoint" URL.) |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the correct S3 endpoint URL format for UpCloud object storage?
💡 Result:
UpCloud Managed Object Storage uses an instance-specific S3 endpoint hostname under upcloudobjects.com:
- Public S3 endpoint:
https://<endpoint>.upcloudobjects.com(example:https://abcd1.upcloudobjects.com) [1] - Private S3 endpoint (same format, with
-private):https://<endpoint>-private.upcloudobjects.com(example:https://mud5q-private.upcloudobjects.com) [2] - Utility-network “internal” endpoint (used in some S3 clients like
s3fs):https://<endpoint>-internal.<dc>.upcloudobjects.com(example:https://my-object-storage-internal.sg-sin1.upcloudobjects.com) [3]
Sources: [1] [2] [3]
Use <endpoint> instead of <string> for the placeholder.
The URL template should be https://<endpoint>.upcloudobjects.com based on UpCloud's endpoint format. The <string> placeholder is vague and should be replaced with <endpoint> to clearly indicate what this field represents. The instruction to use the "S3 endpoint" URL is correct.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@readme/apps/sync/s3.md` at line 79, Replace the vague placeholder in the URL
template `https://<string>.upcloudobjects.com` with
`https://<endpoint>.upcloudobjects.com` in the README entry so the placeholder
clearly indicates the UpCloud S3 endpoint; update the text near the URL example
that currently references "S3 endpoint" if needed to match the `<endpoint>`
placeholder.
|
Please address CodeRabbit's comments |
|
Closing stale PR |
2 participants
Edited the UpCloud section of the s3 readme to reflect new URL style, also provided a region example.