refactor(dp): remove readiness TCP fallback#16174
Draft
Conversation
Remove ReadinessUnixSocketDisabled, FeatureReadinessUnixSocket, and ReadinessPort. Unix socket is now the only readiness reporter mode. Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Contributor
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
When KUMA_DATAPLANE_RUNTIME_SOCKET_DIR is set to a custom path (e.g. /tmp/kuma-dp), the directory was never created in run.go. Components starting concurrently (access-log streamer) tried to create FIFOs inside the missing directory, causing a startup crash. Create SocketDir early, before components are launched. Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Port 9902 (TCP readiness reporter) was removed but e2e test framework still port-forwarded to 9902 for Envoy admin access. Fix by: - Adding wildcard '/' route on non-TLS admin listener (9901) when Envoy admin is on UDS, routing through readiness reporter proxy - Changing EnvoyAdminDefaultSpec from 9902 to 9901 - Updating all hardcoded RemotePort: 9902 in env.go files to 9901 - Fixing inside-pod localhost:9902 access in locality LB test Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Unix socket is the default readiness reporter mode since v2.9.0. Remove the TCP fallback (
ReadinessUnixSocketDisabled,ReadinessPort) and the feature flag (FeatureReadinessUnixSocket) that guarded it. Unix socket is now the only mode.Implementation information
ReadinessUnixSocketDisabledandReadinessPortfromDataplaneconfig and bootstrap requestFeatureReadinessUnixSocketfeature flag constantFieldDataplaneReadinessPortmetadata field andGetReadinessPort()admin_proxy_generatornow unconditionally uses unix socket endpoint for readiness cluster--unix-socketwhenenvoyAdminUnixSocket=trueKUMA_READINESS_UNIX_SOCKET_DISABLED+KUMA_READINESS_PORTwithKUMA_DATAPLANE_RUNTIME_SOCKET_DIRCloses #14039