compatibility-versions: Move kind-upgrade.sh usage function to the top

[gkapetanakis]

The usage function was used before it was defined, which caused the script to crash instead of printing out the usage string when wrong arguments were passed to it.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gkapetanakis / name: George Kapetanakis (923a8bf)

[k8s-ci-robot]

Welcome @gkapetanakis!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @gkapetanakis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gkapetanakis
Once this PR has been reviewed and has the lgtm label, please assign aaron-prindle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• experiment/compatibility-versions/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

this script is being used as a library:
https://github.com/search?q=repo%3Akubernetes%2Ftest-infra%20experiment%2Fcompatibility-versions%2Fkind-upgrade.sh&type=code

[siyuanfoundation]

The usage function was used before it was defined, which caused the script to crash instead of printing out the usage string when wrong arguments were passed to it.

Is there an example of the crash?

[gkapetanakis]

Right now the script seems to only be called by the upgrade_cluster_components function (thanks Ben for pointing this out), which calls it with correct arguments, so existing code works correctly.

What I meant though is that if the script is called for whatever reason with incorrect arguments or with --help (./kind-upgrade.sh invalid_arg or ./kind-upgrade.sh --help) and if no errors happen before it calls parse_args, instead of the usage message being printed, the following error occurs: ./kind-upgrade.sh: line 60: usage: command not found).