Kubespray image-builder presubmit canary build validation

[Srishti-j18]

What this PR does / why we need it

This PR adds a Kubespray presubmit job to validate test-infra/image-builder.
I’m raising this as part of the Kubespray CI automation work tracked in:

• [CI] automate building OS images for supported/CI tested distribution kubernetes-sigs/kubespray#12383
• Context: [CI] automate building OS images for supported/CI tested distribution kubernetes-sigs/kubespray#12383 (comment)

This is safe and useful regardless of the final registry migration path (related discussion: kubernetes-sigs/kubespray#13105).

Note on runtime image

This job uses the existing Kubespray presubmit runtime image:

• quay.io/kubespray/kubespray:v2.13.0

This is intentional for low risk and consistency with current jobs. Any runtime image/registry migration will be handled in follow-up work after a decision is made in kubernetes-sigs/kubespray#13105.

[k8s-ci-robot]

Welcome @Srishti-j18!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Srishti-j18. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tico88612]

/uncc atoms
/cc tico88612 VannTen

[VannTen]

This should have the -e kubevirt_images_push=false ?

[Srishti-j18]

I didn’t add it initially because --syntax-check does not execute the push tasks, but yes, we can add -e kubevirt_images_push=false to make the non-push intent explicit.

[VannTen]

Oh I was wondering about the --syntax-check, does it skip the build as well ?

[Srishti-j18]

Yes, --syntax-check skips the build as well. It validates that the playbook can be parsed, but it does not execute any tasks, so neither build nor push steps run.

I saw here-
https://docs.ansible.com/projects/ansible/latest/cli/ansible-playbook.html

[VannTen]

Let's drop it then, we do want to validate the build works.

[Srishti-j18]

/cc @tico88612 @yankay @VannTen

Hi , After kubernetes-sigs/kubespray#13128, this is the follow-up PR for review. Please take a look if you find time.
I’ve made the changes based on VannTen’s latest review.

[Srishti-j18]

/test pull-kubespray-kubevirt-image-builder-validate

[k8s-ci-robot]

@Srishti-j18: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-kubespray-kubevirt-image-builder-validate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test

[Srishti-j18]

/test pull-kubespray-kubevirt-image-builder-validate

[k8s-ci-robot]

@Srishti-j18: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-test-infra-gubernator

/test pull-test-infra-kubekins-e2e-v2-image-build

/test pull-test-infra-misc-image-build-test

/test pull-test-infra-prow-checkconfig

/test pull-test-infra-unit-test

/test pull-test-infra-verify-cri-o

/test pull-test-infra-verify-lint

Use /test all to run the following jobs that were automatically triggered:

pull-test-infra-gubernator

pull-test-infra-prow-checkconfig

pull-test-infra-unit-test

pull-test-infra-verify-lint

Details

In response to this:

/test pull-kubespray-kubevirt-image-builder-validate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Srishti-j18]

/test pull-kubespray-yamllint

[k8s-ci-robot]

@Srishti-j18: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-test-infra-gubernator

/test pull-test-infra-kubekins-e2e-v2-image-build

/test pull-test-infra-misc-image-build-test

/test pull-test-infra-prow-checkconfig

/test pull-test-infra-unit-test

/test pull-test-infra-verify-cri-o

/test pull-test-infra-verify-lint

Use /test all to run the following jobs that were automatically triggered:

pull-test-infra-gubernator

pull-test-infra-prow-checkconfig

pull-test-infra-unit-test

pull-test-infra-verify-lint

Details

In response to this:

/test pull-kubespray-yamllint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Srishti-j18]

On a kubernetes/test-infra PR, Prow only exposes the test-infra validation jobs for /test. Jobs like pull-kubespray-yamllint or the new pull-kubespray-kubevirt-image-builder-validate are defined for Kubespray PRs, so they are not directly triggerable from the test-infra PR itself.

So, do we have no way to test this before the merge?

Does this mean pull-kubespray-kubevirt-image-builder-validate only becomes directly testable after merge, or by opening a Kubespray PR once the job exists in the merged test-infra config?

[VannTen]

Does this mean pull-kubespray-kubevirt-image-builder-validate only becomes directly testable after merge, or by opening a Kubespray PR once the job exists in the merged test-infra config?

Yes, at least, that's how I understand it.

[VannTen]

/lgtm
/approve

[VannTen]

Not sure why we need that specific tag, it's kinda ancient ?
A generic Ansible image (if there is such a thing) would probably do the job.
Let's merge like this for now and iterate as needed.

[Srishti-j18]

Yeah, I mostly followed the existing pattern here to keep the change low-risk. I can update it in the next round of changes.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Srishti-j18, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-sigs/kubespray/OWNERS [VannTen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@Srishti-j18: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key kubespray-presubmits.yaml using file config/jobs/kubernetes-sigs/kubespray/kubespray-presubmits.yaml

Details

In response to this:

What this PR does / why we need it

This PR adds a Kubespray presubmit job to validate test-infra/image-builder.
I’m raising this as part of the Kubespray CI automation work tracked in:

• [CI] automate building OS images for supported/CI tested distribution kubernetes-sigs/kubespray#12383
• Context: [CI] automate building OS images for supported/CI tested distribution kubernetes-sigs/kubespray#12383 (comment)

This is safe and useful regardless of the final registry migration path (related discussion: kubernetes-sigs/kubespray#13105).

Note on runtime image

This job uses the existing Kubespray presubmit runtime image:

• quay.io/kubespray/kubespray:v2.13.0

This is intentional for low risk and consistency with current jobs. Any runtime image/registry migration will be handled in follow-up work after a decision is made in kubernetes-sigs/kubespray#13105.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.