frontend: Settings: make websocket multiplexer a setting#5118
Open
Vikaspal8923 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
frontend: Settings: make websocket multiplexer a setting#5118Vikaspal8923 wants to merge 1 commit intokubernetes-sigs:mainfrom
Vikaspal8923 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Vikaspal8923 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
There's a PR for this here: Apologies, it looks like I didn't link the PR to the issue or notice that you were assigned in early Feb. Maybe we can merge them together, and take bits from both. |
Contributor
Author
|
Ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR makes the WebSocket multiplexer configurable from the frontend Settings page. Users can now enable or disable the multiplexer option from the app Settings UI and persist the choice in the application configuration.
Related Issue
Fixes #4505
Changes
WebSocket multiplexerinfrontend/src/components/App/Settings/Settings.tsxfrontend/src/helpers/websocketMultiplexer.tsfrontend/src/redux/configSlice.tsfrontend/src/components/App/Settings/Settings.General.stories.storyshotfrontend/src/components/App/Notifications/Notifications.stories.tsxfrontend/src/i18n/locales/*/translation.jsonfrontend/src/lib/k8s/api/v2/hooks.tsfrontend/src/lib/k8s/api/v2/useKubeObjectList.tsfrontend/src/lib/k8s/api/v2/useKubeObjectList.test.tsxSteps to Test
WebSocket multiplexersetting is visible.screenshot :
Screencast from 2026-04-11 03-19-08.webm
Notes for the Reviewer