Skip to content

frontend: Settings: make websocket multiplexer a setting#5118

Open
Vikaspal8923 wants to merge 1 commit intokubernetes-sigs:mainfrom
Vikaspal8923:websocket_multiplexer
Open

frontend: Settings: make websocket multiplexer a setting#5118
Vikaspal8923 wants to merge 1 commit intokubernetes-sigs:mainfrom
Vikaspal8923:websocket_multiplexer

Conversation

@Vikaspal8923
Copy link
Copy Markdown
Contributor

PR Summary

This PR makes the WebSocket multiplexer configurable from the frontend Settings page. Users can now enable or disable the multiplexer option from the app Settings UI and persist the choice in the application configuration.

Related Issue

Fixes #4505

Changes

  • Added a new Settings control for WebSocket multiplexer in frontend/src/components/App/Settings/Settings.tsx
  • Added helper logic to manage multiplexer behavior in frontend/src/helpers/websocketMultiplexer.ts
  • Persisted the new config option in Redux via frontend/src/redux/configSlice.ts
  • Added Storybook coverage for the Settings change in frontend/src/components/App/Settings/Settings.General.stories.storyshot
  • Updated related story tests in frontend/src/components/App/Notifications/Notifications.stories.tsx
  • Added translations for the new setting label in all supported locales under frontend/src/i18n/locales/*/translation.json
  • Adjusted related K8s API hook logic and tests to ensure the new setting does not break existing data refresh behavior:
    • frontend/src/lib/k8s/api/v2/hooks.ts
    • frontend/src/lib/k8s/api/v2/useKubeObjectList.ts
    • frontend/src/lib/k8s/api/v2/useKubeObjectList.test.tsx

Steps to Test

  1. Start the frontend app locally.
  2. Open the Settings page.
  3. Verify the new WebSocket multiplexer setting is visible.
  4. Toggle the option and confirm the state is saved.
  5. Ensure WebSocket-related data flows continue working correctly.

screenshot :
Screencast from 2026-04-11 03-19-08.webm

Notes for the Reviewer

  • Please verify the new translation strings are correctly added across all locales.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vikaspal8923
Once this PR has been reviewed and has the lgtm label, please assign ashu8912 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2026
@illume
Copy link
Copy Markdown
Contributor

illume commented Apr 11, 2026

There's a PR for this here:

Apologies, it looks like I didn't link the PR to the issue or notice that you were assigned in early Feb. Maybe we can merge them together, and take bits from both.

@Vikaspal8923
Copy link
Copy Markdown
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make websocket multiplexer a setting rather than just an environment variable

3 participants