fix(sidecar-controller): retry conflict when clearing content status#1405
fix(sidecar-controller): retry conflict when clearing content status#1405TOGEP wants to merge 1 commit intokubernetes-csi:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TOGEP The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @TOGEP. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds
RetryOnConflicthandling to the sidecar delete flow.Specifically, it ensures that clearing
VolumeSnapshotContentstatusafter CSI delete succeeds is retried on transient conflicts.
Changes include:
clearVolumeContentStatusnow usesretry.RetryOnConflict.VolumeSnapshotContenton each retry before callingUpdateStatus.Tests:
pkg/sidecar-controller/snapshot_delete_test.go.1-3bto verify that a transientUpdateStatusconflict is retried and eventually succeeds.apierrors.NewConflict) to align withRetryOnConflictbehavior.Which issue(s) this PR fixes:
Related to #748
Special notes for your reviewer:
Does this PR introduce a user-facing change?: