Support added for architecture riscv64 (linux)#1481
Support added for architecture riscv64 (linux)#1481Opvolger wants to merge 1 commit intokubernetes-csi:masterfrom
Conversation
|
Welcome @Opvolger! |
|
Hi @Opvolger. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b3f6dcb to
61fa5a9
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Opvolger The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| CSI_PROW_SIDECAR_E2E_IMPORT_PATH="github.com/kubernetes-csi/external-provisioner/v5/test/e2e" | ||
| CSI_PROW_SIDECAR_E2E_PATH="github.com/kubernetes-csi/external-provisioner/test/e2e" | ||
| CSI_PROW_BUILD_PLATFORMS="linux amd64 amd64; linux ppc64le ppc64le -ppc64le; linux s390x s390x -s390x; linux arm arm -arm; linux arm64 arm64 -arm64; linux arm arm/v7 -armv7; linux riscv64 riscv64 -riscv64; windows amd64 amd64 .exe nanoserver:1809 servercore:ltsc2019; windows amd64 amd64 .exe nanoserver:ltsc2022 servercore:ltsc2022" |
There was a problem hiding this comment.
This belongs into https://github.com/kubernetes-csi/csi-release-tools/blob/de06a09a7a68bc8da0a275094ade1f5ea7a1a995/prow.sh#L81. As result, all CSI sidecars will be built for riscv64 (once the release-tools are propagated to all repos, which happens with every golang bump for CVEs...)
Still, the question is, how are we going to support this platform? In the CSI community, we have a lot of Linux + amd64 expertise, with some arm / arm64 when needed. We have no riscv64 to test with.
There was a problem hiding this comment.
The problem with all the build is, that the debian base image (used in some CSI projects) has no riscv64 version (yet). See kubernetes/release#4303 and kubernetes/kubernetes#116686
Now that riscv64 support is available for the distroless Docker base image (GoogleContainerTools/distroless#2001), add linux/riscv64 to the default build platforms so all CSI sidecar repos pick it up automatically. Related: kubernetes-csi/livenessprobe#403 Related: kubernetes-csi/external-provisioner#1481
What type of PR is this?
/kind feature
What this PR does / why we need it:
Now that riscv64 support is available for the distroless Docker image, it's possible to add support for riscv64.
See pull request: GoogleContainerTools/distroless#2001
I tested this combination with my riscv64 Kubernetes cluster (k0s with smb-provider). See: https://www.youtube.com/watch?v=WERPNNyzqqs
Riscv64 support can now be slowly added to Docker images that relied on "gcr.io/distroless/static:latest".
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: