inherit for before and after instead of hamburger-active-layer-color;#94
Open
paul-git wants to merge 3 commits intojonsuh:masterfrom
Open
inherit for before and after instead of hamburger-active-layer-color;#94paul-git wants to merge 3 commits intojonsuh:masterfrom
paul-git wants to merge 3 commits intojonsuh:masterfrom
Conversation
…layer-color; Since the ::before and ::after css pseudo elements are not accessible from Javascript, the color of the two bars at the bottom and top cannot be changed at runtime. By using "inherit" they will take over the color of middle bar thus the color can be changed dinamically.
"inherit" for ::before and ::after instead of $hamburger-active-layer-color
Reintegrate last updates from jonsuh/hamburger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the ::before and ::after css pseudo elements are not accessible from Javascript, the color of the two bars at the bottom and top cannot be changed at runtime. By using "inherit" they will take over the color of middle bar thus the color can be changed dinamically.