feat: Enable using something other than Express for a web server#1809
Open
joeyguerra wants to merge 2 commits intomainfrom
Open
feat: Enable using something other than Express for a web server#1809joeyguerra wants to merge 2 commits intomainfrom
joeyguerra wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a plugin architecture for HTTP servers in Hubot, allowing developers to use alternatives to Express. The implementation adds a base HttpServerPort class that defines the HTTP server interface, and refactors the existing Express integration into an ExpressHttpServerPort adapter.
Key changes:
- Introduces
HttpServerPortbase class with stub implementations of HTTP server methods - Creates
ExpressHttpServerPortas the default Express implementation - Refactors
Robotconstructor to accept a server factory function instead of a boolean - Adds CLI option
--httpdserverto specify custom HTTP server modules
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ports/HttpServerPort.mjs | New base class defining the HTTP server port interface with stub methods |
| src/ports/ExpressHttpServerPort.mjs | Express implementation of HttpServerPort with configuration via environment variables |
| src/Robot.mjs | Refactored to use server factory pattern and converted setupExpress to static method |
| bin/Hubot.mjs | Added CLI option and logic to load custom HTTP server modules |
| test/contracts/HttpServer_test.mjs | New contract tests for HttpServerPort API |
| test/Robot_test.mjs | Added test for non-Express HTTP server (with missing implementation) |
| test/Hubot_test.mjs | Removed debug console.log statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I want to use a different web server - not Express. So I need a way for Hubot to load a different one.
ExpressHttpServerPortfor reference.