binder: Remove redundant ServerInbound.serverTransport field#12734
Open
jdcormie wants to merge 1 commit intogrpc:masterfrom
Open
binder: Remove redundant ServerInbound.serverTransport field#12734jdcormie wants to merge 1 commit intogrpc:masterfrom
jdcormie wants to merge 1 commit intogrpc:masterfrom
Conversation
ejona86
approved these changes
Apr 16, 2026
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
An alternative approach is to store the data in the subclass, which removes the need for any generics. You'd have a abstract BinderTransport getTransport() in the base class and store the more precise field in the subclasses. And the subclasses are free to provide a more precise return value like BinderClientTransport getTransport() (but it seems that is unnecessary in this case).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.