defer delete converted strings in the tests in Raindrops#188
defer delete converted strings in the tests in Raindrops#188rmonnet merged 2 commits intoexercism:mainfrom
defer delete converted strings in the tests in Raindrops#188Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
closes #186 |
rmonnet
left a comment
There was a problem hiding this comment.
I concur with the change, the caller should be responsible for cleaning up the allocated string. But additional changes are required.
- The
.meta/example.odinfile needs to be modified so it doesn't delete thestrings.Buildervariable containing the returned string. - An additional
docs/instructions.append.mdfile must be created to explain that the responsibility to clean up the generated string memory belongs to the caller. (a couple of lines is all that is needed, look at theforthexercise for an example of format for this file).
Please make the requested changes and resubmit.
rmonnet
left a comment
There was a problem hiding this comment.
Latest commit looks good, merging now.
https://exercism.org/tracks/odin/exercises/raindrops