Simple attribute indentation fails with codemod mock#94
Open
tylerturdenpants wants to merge 3 commits intoember-template-lint:masterfrom
tylerturdenpants:attrs-on-same-line
Open
Simple attribute indentation fails with codemod mock#94tylerturdenpants wants to merge 3 commits intoember-template-lint:masterfrom tylerturdenpants:attrs-on-same-line
tylerturdenpants wants to merge 3 commits intoember-template-lint:masterfrom
tylerturdenpants:attrs-on-same-line
Conversation
rwjblue
reviewed
Aug 16, 2019
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
FWIW, this is less of a bug per-se and more of a missing feature. When creating the new ElementNode we have no way to figure out what “join” mechanism (e.g. \n vs ) to use so we default to .
We should definitely give an api for this (or try to discern a default from the rest of the template).
Contributor
Author
|
When I inspect the newly created nodes I do see location information that seems to reference its old location. What's going on there? |
Contributor
Author
|
I guess the location info is useless if you dont know what "join" mechanism is? |
Contributor
Author
|
I think its time for an API for this since this is the last major hurdle to release the angle-bracket-codemod using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small example of #84 using existing test.