bump minimum glimmer syntax and fix type issues#1005
Open
mansona wants to merge 1 commit intoember-template-lint:masterfrom
Open
bump minimum glimmer syntax and fix type issues#1005mansona wants to merge 1 commit intoember-template-lint:masterfrom
mansona wants to merge 1 commit intoember-template-lint:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is trying to fix issues like ember-template-lint/ember-template-lint#3339 by bumping the minimum
@glimmer/syntaxthat ember-template-recast uses so that it includes this fix: glimmerjs/glimmer-vm#1720I don't know the exact specifics but I assume this doesn't need to be a major since the bump is a direct dependency? Any thoughts on the server of this?