fix: increase performance test tolerance to prevent flaky failures#64
Open
Yanhu007 wants to merge 1 commit intoelliotchance:masterfrom
Open
fix: increase performance test tolerance to prevent flaky failures#64Yanhu007 wants to merge 1 commit intoelliotchance:masterfrom
Yanhu007 wants to merge 1 commit intoelliotchance:masterfrom
Conversation
The O(1) performance assertions used a tolerance of 0.5x the baseline (res1.NsPerOp), which is too tight on faster runtimes like Go 1.24 where absolute timings are smaller and GC/scheduler variance is relatively larger. Increase tolerance to 1.0x the baseline, which still validates O(1) behavior (res4 should be within 2x of res1) while being robust against benchmark noise. Fixes elliotchance#61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61
Problem
TestGetElement/Performance(and similar performance subtests forSetandGet) intermittently fail on Go 1.24+ because the tolerance of0.5 * res1.NsPerOp()is too tight.When the absolute timings are small (e.g., 48 ns/op), a 50% tolerance allows only 24 ns difference, but benchmark noise can easily exceed that:
Fix
Increase the tolerance from
0.5xto1.0xthe baseline. This still validates O(1) behavior (the 4x-larger map should complete within 2x the time of the smaller map) while being robust against benchmark variance on fast runtimes.All tests pass.
This change is