Skip to content

feat(controller-admin-jobs): add trigger support to job creation api#2110

Draft
shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd/job-trigger-admin-api
Draft

feat(controller-admin-jobs): add trigger support to job creation api#2110
shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd/job-trigger-admin-api

Conversation

@shiyasmohd
Copy link
Copy Markdown
Contributor

Enable explicit trigger configuration (OneShot, Interval, Cron) for all job types through the admin API, with OneShot as the default.

  • Add trigger field to CreateJobRequest variants and JobDescriptor constructors
  • Always serialize trigger in job descriptor, defaulting to OneShot when omitted
  • Explicitly set Trigger::OneShot in dataset deploy handler
  • Add trigger field to admin-client CreateJobRequest::Gc
  • Add integration tests for all trigger types (OneShot, Interval, Cron)

@shiyasmohd shiyasmohd self-assigned this Apr 8, 2026
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/job-trigger-admin-api branch from 5fc0b6c to e1b918b Compare April 8, 2026 11:44
@shiyasmohd shiyasmohd requested review from LNSD and mitchhs12 April 10, 2026 09:59
Copy link
Copy Markdown
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this, we need to handle the trigger unregistration flow. Otherwise, we'll be accumulating tokio tasks

@shiyasmohd shiyasmohd marked this pull request as draft April 15, 2026 06:53
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/job-trigger-admin-api branch from e1b918b to f9c9822 Compare April 15, 2026 09:05
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/job-trigger-admin-api branch from f9c9822 to 23f2862 Compare April 15, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants