feat(controller-admin-jobs): add trigger support to job creation api#2110
Draft
shiyasmohd wants to merge 1 commit intomainfrom
Draft
feat(controller-admin-jobs): add trigger support to job creation api#2110shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd wants to merge 1 commit intomainfrom
Conversation
5fc0b6c to
e1b918b
Compare
LNSD
reviewed
Apr 14, 2026
Contributor
LNSD
left a comment
There was a problem hiding this comment.
Before merging this, we need to handle the trigger unregistration flow. Otherwise, we'll be accumulating tokio tasks
e1b918b to
f9c9822
Compare
f9c9822 to
23f2862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable explicit trigger configuration (OneShot, Interval, Cron) for all job types through the admin API, with OneShot as the default.
CreateJobRequestvariants andJobDescriptorconstructorsOneShotwhen omittedTrigger::OneShotin dataset deploy handlerCreateJobRequest::Gc