[release/10.0] Fix Native AOT-incompatible reflection in CalendarTestBase#126817
Merged
JulieLeeMSFT merged 2 commits intorelease/10.0from Apr 16, 2026
Merged
[release/10.0] Fix Native AOT-incompatible reflection in CalendarTestBase#126817JulieLeeMSFT merged 2 commits intorelease/10.0from
JulieLeeMSFT merged 2 commits intorelease/10.0from
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a684b399-ef09-407d-8de5-9e4680d4f736 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Japanese calendar tests failing due to null reference exception
Fix Native AOT-incompatible reflection in CalendarTestBase
Apr 13, 2026
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore NativeAOT test compatibility by adjusting reflection usage in the Japanese calendar test infrastructure (CalendarTestBase) on release/10.0, after a prior change introduced trimming/AOT-incompatible reflection patterns.
Changes:
- Reworks reflection used to compute the ICU-specific
JapaneseCalendarminimum supported date (era ticks) to be more NativeAOT-friendly.
tarekgh
approved these changes
Apr 13, 2026
JulieLeeMSFT
added
Servicing-consider
Member
|
Please check build/test failures. |
Member
|
/ba-g native aot outerloop CoreCLR test tree outerloop is known to be broken. the one build break in the libs leg on osx arm64 is known too. the rest of native aot outerloop libs legs that this is expected to fix is indeed fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change #122373 broke native AOT testing because it introduced trimming incompatible code into a test.
/cc @MichalStrehovsky
Customer Impact
Test only change. We broke release/10.0 using a release/10.0-only change.
Regression
Testing
Outerloop run.
Risk
Low. Test only.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.