Draft
Conversation
Collaborator
|
Why do we need the |
dmitry-shibanov
force-pushed
the
v-dmshib/update-for-release
branch
3 times, most recently
from
9a71e4e to
3632aa4
Compare
Comment on lines
+2
to
+6
| on: | ||
| push: | ||
| pull_request: | ||
| schedule: | ||
| - cron: 0 0 * * * |
Collaborator
There was a problem hiding this comment.
I suggest to update the event configuration in the final version of yml:
push:
branches:
- master
paths-ignore:
- '**.md'
pull_request:
paths-ignore:
- '**.md'
e671865 to
e7884ed
Compare
| { | ||
| "version": "1.2.3", | ||
| "stable": true, | ||
| "release_url": "https://github.com/actions/sometool/releases/tag/1.2.3-20200402.6", |
Collaborator
There was a problem hiding this comment.
I think we can delete this file
| expect(fileName).toBe('go1.13.7.windows-amd64.zip'); | ||
| it('can mock manifest versions', async () => { | ||
| let versions: tc.IToolRelease[] | null = await tc.getManifestFromRepo( | ||
| 'actions', |
Collaborator
There was a problem hiding this comment.
I believe we don't need the following tests in the form they currently exist:
- it('can mock manifest versions', async () => {
- it('can find 1.12.17 from manifest on osx', async () => {
- it('can find 12 from manifest on linux', async () => {
- it('can find 10 from manifest on windows', async () => {
These "it" blocks test the functions located in the actions/tool-cache repository (getManifestFromRepo, findFromManifest etc.) and we don't have tests with several functions from installer.ts script (getGo, installGoVersion, extractGoArchive etc.).
dmitry-shibanov
force-pushed
the
v-dmshib/update-for-release
branch
from
350d374 to
fbbee91
Compare
dmitry-shibanov
force-pushed
the
v-dmshib/update-for-release
branch
from
8afde2f to
ddc7688
Compare
* add tests * fixing tests * change names of it * resolve comments Co-authored-by: Dmitry Shibanov <v-dmshib@microsoft.com>
* fix comments * formatting Co-authored-by: Dmitry Shibanov <v-dmshib@microsoft.com>
Co-authored-by: Dmitry Shibanov <v-dmshib@microsoft.com>
Lucho100789
approved these changes
Mar 12, 2023
| }); | ||
| if (goFile) { | ||
| core_1.debug(`matched ${candidate.version}`); | ||
| core.debug(`matched ${candidate.version}`); |
|
dmitry-shibanov
pushed a commit
that referenced
this pull request
Nov 7, 2023
Improve documentation regarding dependencies caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since added go-versions was added to actions, we need add logic to install go from our releases.