Add SET TAGS profiling scripts and connector PROFILE instrumentation#780
Draft
tejassp-db wants to merge 3 commits intomainfrom
Draft
Add SET TAGS profiling scripts and connector PROFILE instrumentation#780tejassp-db wants to merge 3 commits intomainfrom
tejassp-db wants to merge 3 commits intomainfrom
Conversation
Profiling scripts to compare direct ALTER SET TAGS vs reading from information_schema before writing. Includes scripts for column tags, table tags, information_schema reads, cleanup, and chart generation. Credentials are loaded from examples/credentials.env (gitignored). Copy credentials.env.example and fill in workspace details. Connector instrumentation adds [PROFILE] log lines in the Thrift backend retry loop and urllib3 retry policy to capture per-attempt timing, statement IDs, retry decisions, and SQL text. Co-authored-by: Isaac
Pass enable_telemetry=False to sql.connect() to avoid telemetry HTTP calls during profiling runs. Co-authored-by: Isaac
- All 4 profiling scripts now accept --tables-per-iteration (defaults to --threads, i.e. 1 table per thread per iteration). - NUM_TABLES bumped to 128. - plot_comparison.py generates separate PNGs for table-level comparison (wall-clock, tables/sec) and individual operation detail (ops/sec, P50, P99, max). Column tags and table tags get their own PNGs. - Chart labels spell out parameters (columns, tags_per_column, tables). - All scripts pass enable_telemetry=False to sql.connect(). Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/to compare directALTER … SET TAGSvs. read-from-information_schema-then-write, for both column and table tags. Includes cleanup, chart generation(
plot_comparison.py), and aPROFILING_README.md.[PROFILE]log lines inthrift_backend.pyandauth/retry.pyto capture per-attempt timing, statement IDs, retry decisions, and (truncated) SQL text.enable_telemetry=Falseand load credentials from gitignoredexamples/credentials.env.