Skip to content

Replace third-party DCO action with custom script#769

Merged
vikrantpuppala merged 1 commit intomainfrom
fix/dco-check-workflow
Apr 13, 2026
Merged

Replace third-party DCO action with custom script#769
vikrantpuppala merged 1 commit intomainfrom
fix/dco-check-workflow

Conversation

@vikrantpuppala
Copy link
Copy Markdown
Contributor

Summary

  • Replaced the unreliable tisonkun/actions-dco third-party action with a custom inline bash script that checks each commit for a Signed-off-by line
  • Aligned the DCO check implementation with databricks-sql-go for consistency across repos
  • Scoped the workflow trigger to opened, synchronize, and reopened PR events on main (instead of all PR events)
  • Removed unnecessary pull-requests: write permission since the workflow no longer posts comments

Test plan

  • Verify the DCO check passes on this PR (commit is signed off)
  • Open a test PR without sign-off to confirm the check fails with clear error output

This pull request was AI-assisted by Isaac.

The tisonkun/actions-dco action has been unreliable. Replace it with an
inline bash script (matching databricks-sql-go) that checks each commit
for a Signed-off-by line, provides clear per-commit feedback, and scopes
the trigger to opened/synchronize/reopened events on main.

Co-authored-by: Isaac
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
@vikrantpuppala vikrantpuppala merged commit e056275 into main Apr 13, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants