FlatExpression: add SE-mirroring type-inferring factory overloads#514
Draft
Copilot wants to merge 2 commits intocopilot/data-oriented-expression-optimizationfrom
Draft
FlatExpression: add SE-mirroring type-inferring factory overloads#514Copilot wants to merge 2 commits intocopilot/data-oriented-expression-optimizationfrom
Copilot wants to merge 2 commits intocopilot/data-oriented-expression-optimizationfrom
Conversation
Agent-Logs-Url: https://github.com/dadhi/FastExpressionCompiler/sessions/fcaf9e30-6173-483d-9806-5ff098307f83 Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Explore data-oriented flat expression tree implementation
FlatExpression: add SE-mirroring type-inferring factory overloads
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpressionTreefactory methods required an explicitTypeargument everywhere, making it impossible to swapExpression.Add(a, b)fortree.Add(a, b)without callers threading types manually.Changes
Add,Subtract,Multiply,Divide,Moduloinfer result type from the left operand (NodeAt(left).Type); explicit-type overloads preservedNegate(operand)infers from operand;Assign(target, value)infers from targetBinarywithout explicit type —Binary(nodeType, left, right)infers from left; explicit-type variant unchangedNotEqual,LessThan,LessThanOrEqual,GreaterThan,GreaterThanOrEqual→typeof(bool);AndAlso,OrElse→ infer from left (matches SE behaviour for user-defined operators; forbooloperands the inferred type is alreadybool)