Skip to content

Update hasProp to handle object not derived from Object #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moo3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update hasProp to handle object not derived from Object #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad3400
Update hasProp to handle object not derived from Object
moo3 May 27, 2015
81d2a0f
Updated to use refProto
moo3 Jun 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ define(function (require) {

// for better compression
function hasProp (object, name) {
return object.hasOwnProperty(name);
return Object.hasOwnProperty.call(object, name);
Copy link
Copy Markdown
Member

@unscriptable unscriptable Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing, imho. The way this is written, it appears that there is a method, hasOwnProperty defined on the Object constructor. However, hasOwnProperty is only defined on Function.prototype, not on Object. Perhaps you could use the refProto variable from above?

return refProto.hasOwnProperty.call(object, name);

}

function _keys (object) {
Expand Down