docs: add asqav governance and audit trail integration#5337
docs: add asqav governance and audit trail integration#5337jagmarques wants to merge 3 commits intocrewAIInc:mainfrom
Conversation
|
Note for maintainers: this PR was authored by an AI coding assistant (Claude Code). Please apply the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad14fabf69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| agents=[researcher], | ||
| tasks=[task], | ||
| process=Process.sequential, | ||
| callbacks=[hook], |
There was a problem hiding this comment.
callbacks argument in Crew example
This snippet passes callbacks=[hook] to Crew(...), but Crew defines step_callback and task_callback (in lib/crewai/src/crewai/crew.py) and does not expose a callbacks field. In practice, users following this guide will think Asqav is wired in while the hook is never attached, so audit records are not captured as documented. Please switch the example to a supported Crew callback parameter so the integration actually executes.
Useful? React with 👍 / 👎.
|
The callbacks issue flagged by the bot was addressed - the current version uses step_callback and task_callback directly, which is the correct CrewAI pattern. |
|
Just checking if this is ready for review. Happy to address any feedback. |
Adds a docs page for Asqav covering the AsqavCrewHook callback for signed audit trails and the asqav-compliance CI scanner. Updates docs.json navigation for all language versions.
- Use correct import path: asqav.extras.crewai (not asqav.integrations.crewai) - Use correct constructor param: agent_name (not project) - Use step_callback and task_callback instead of non-existent callbacks param
- Fix GitHub URL: github.com/asqav/asqav -> github.com/jagmarques/asqav-sdk - Fix algorithm: Ed25519 -> ML-DSA-65 (server-side signing) - Fix env var: ASQAV_SIGNING_KEY -> ASQAV_API_KEY - Fix docs URLs: asqav.github.io/docs -> asqav.com/docs/integrations - Remove hallucinated "asqav keygen" CLI command - Remove hallucinated "asqav verify --log" CLI command - Remove hallucinated "asqav-compliance scan" CI scanner section - Remove hallucinated local JSONL logging (SDK doesn't write local files) - Remove hallucinated audit log format section
jagmarques
force-pushed
the
docs/asqav-governance-integration
branch
from
0bdf9cc to
a2258dc
Compare
|
Rebased on latest main. Ready for review. |
|
Hi! We're not accepting external tool/vendor integrations in core docs. Please see https://docs.crewai.com/en/guides/tools/publish-custom-tools |
|
Thanks Greyson, understood. Closing this and will publish as a custom tool per the guide. Appreciate the pointer. |
2 participants
Adds asqav as a governance tool integration. Covers the CrewAI callback hook for signed audit trails and the CI compliance scanner. PraisonAI merged the equivalent docs PR today (MervinPraison/PraisonAIDocs#55).